Fix compilation issue after change to Subject interface in core and bump to 3.2.0#5423
Merged
shikharj05 merged 7 commits intoopensearch-project:mainfrom Jun 23, 2025
Merged
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
requested review from
DarshitChanpura,
RyanL1997,
derek-ho,
nibix,
peternied,
reta,
shikharj05 and
willyborankin
as code owners
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
changed the title
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
…into run-as-compile
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5423 +/- ##
==========================================
- Coverage 72.42% 72.42% -0.01%
==========================================
Files 394 393 -1
Lines 24292 24286 -6
Branches 3713 3714 +1
==========================================
- Hits 17594 17588 -6
- Misses 4868 4869 +1
+ Partials 1830 1829 -1
🚀 New features to boost your workflow:
|
willyborankin
approved these changes
Jun 21, 2025
nibix
approved these changes
Jun 23, 2025
shikharj05
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix compilation issue after change to Subject interface in core
Interface changed in opensearch-project/OpenSearch#18570 to use a CheckedRunnable to avoid throwing a generic Exception with using Callable.
This PR also renames a few classes for maintainability.
Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.